Fixes for searchDialog, RegexHelperDialog, exception logging#477
Open
AndisGrossteins wants to merge 6 commits intoLogExperts:Developmentfrom
Open
Fixes for searchDialog, RegexHelperDialog, exception logging#477AndisGrossteins wants to merge 6 commits intoLogExperts:Developmentfrom
AndisGrossteins wants to merge 6 commits intoLogExperts:Developmentfrom
Conversation
Set SearchDialog.buttonRegexHelper.Autosize
Insert new items into comboBox dataSource - _expressionHistoryList and _testtextHistoryList instead of directly into comboBox.Items.
…dExceptionEventArgs
Moved _logger.Info call into if statement where it should be
Hirogen
reviewed
Oct 2, 2025
Replaced the `Button` control `buttonRegexHelper` with a `LinkLabel` control `linkLabelRegexHelper` to improve the UI for the search dialog. Updated `TabIndex` values across multiple controls to ensure proper tab navigation order. Adjusted properties of `linkLabelRegexHelper` for accessibility and alignment with the new design. Modified `groupBoxOptions` and `groupBoxDirection` controls to reflect the new layout, including size and `TabIndex` adjustments. Removed the declaration of `buttonRegexHelper` and added `linkLabelRegexHelper` in the private fields section.
…UnhandledExceptionEventArgs" This reverts commit 79d59d9.
Hirogen
requested changes
Nov 4, 2025
| labelSearchFor = new Label(); | ||
| checkBoxCaseSensitive = new CheckBox(); | ||
| checkBoxRegex = new CheckBox(); | ||
| linkLabelRegexHelper = new LinkLabel(); |
Collaborator
There was a problem hiding this comment.
Why change it from button to LinkLabel?
Contributor
Author
There was a problem hiding this comment.
To align the control group boxes and also to avoid issues with size of the button and text overflow.
Testing on a high-DPI display was breaking the layout and using LinkLabel seems like a better option for that feature.
I've certainly seen this pattern used before for help in a search dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
Code cleanup and modernization. Should fix #476.
PR Summary
This pull request refactors and modernizes the codebase for improved readability, maintainability, and robustness, while enhancing logging and UI consistency.
comboBoxitem management with encapsulated history lists for better data handling.thisreferences, modernized control properties, and streamlined form setup. (mostly automatic shanges by Visual Studio designer mode)